<p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/1/src/osmo_gsm_tester/obj/enb.py">File src/osmo_gsm_tester/obj/enb.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/1/src/osmo_gsm_tester/obj/enb.py@358">Patch Set #1, Line 358:</a> <code style="font-family:monospace,monospace">    </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Remove this whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/1/src/osmo_gsm_tester/obj/enb.py@364">Patch Set #1, Line 364:</a> <code style="font-family:monospace,monospace">    def get_log_kpis(self):</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm not sure what's the point in splitting between log and kpi, is there some rationale behind this?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/1/src/osmo_gsm_tester/obj/enb.py@368">Patch Set #1, Line 368:</a> <code style="font-family:monospace,monospace">    def get_num_phy_errors(self, kpi):</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">What about this function? looks not related to this patch?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/1/src/osmo_gsm_tester/obj/enb.py@370">Patch Set #1, Line 370:</a> <code style="font-family:monospace,monospace">        return 0 </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">remove trailing whistepace</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/1/src/osmo_gsm_tester/obj/epc.py">File src/osmo_gsm_tester/obj/epc.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/1/src/osmo_gsm_tester/obj/epc.py@124">Patch Set #1, Line 124:</a> <code style="font-family:monospace,monospace">        return {'total_errors': 0, 'total_warnings': 0}        </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">remove trailing whitespace</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601">change 22601</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7c6c9abf73c2fc1d9104ea082bef6ffa0aeeac32 </div>
<div style="display:none"> Gerrit-Change-Number: 22601 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: srs_andre <andre@softwareradiosystems.com> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 01 Feb 2021 14:58:20 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>