This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25224 ) Change subject: CTRL: expose stat_item groups on CTRL ...................................................................... Patch Set 1: (1 comment) Other than the comment regarding the macro, everything LGTM. https://gerrit.osmocom.org/c/libosmocore/+/25224/1/src/ctrl/control_if.c File src/ctrl/control_if.c: https://gerrit.osmocom.org/c/libosmocore/+/25224/1/src/ctrl/control_if.c@736 PS1, Line 736: CTRL_CMD_DEFINE(stat_item, "stat_item *"); IIRC there's a specific macro to define readonly commands, so you don't need to specify dummy get functions and so on. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idace66b37492fe96b2f2e133a69cac7960ca279c Gerrit-Change-Number: 25224 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 24 Aug 2021 08:57:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210824/f3963af9/attachment.htm>