<p style="white-space: pre-wrap; word-wrap: break-word;">Other than the comment regarding the macro, everything LGTM.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/25224">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/25224/1/src/ctrl/control_if.c">File src/ctrl/control_if.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/25224/1/src/ctrl/control_if.c@736">Patch Set #1, Line 736:</a> <code style="font-family:monospace,monospace">CTRL_CMD_DEFINE(stat_item, "stat_item *");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">IIRC there's a specific macro to define readonly commands, so you don't need to specify dummy get functions and so on.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/25224">change 25224</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/25224"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Idace66b37492fe96b2f2e133a69cac7960ca279c </div>
<div style="display:none"> Gerrit-Change-Number: 25224 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 24 Aug 2021 08:57:11 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>