This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23833 ) Change subject: osmo-bts-trx: implement TRXDv2 protocol support ...................................................................... Patch Set 7: (5 comments) https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/include/osmo-bts/scheduler.h File include/osmo-bts/scheduler.h: https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/include/osmo-bts/scheduler.h@256 PS7, Line 256: uint8_t _pdu_num; /*!< Number of this PDU within the datagram */ > you mean the PDU position? This field basically holds the number of parsed PDUs, so when it's 0 we expect TDMA frame number to be present, otherwise it's absent. https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/src/osmo-bts-trx/trx_if.c@726 PS7, Line 726: #define TRX_UL_V2HDR_LEN 1 + 1 + 1 + 1 + 2 + 2 > missing () Ack https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/src/osmo-bts-trx/trx_if.c@852 PS7, Line 852: bi->rssi = -(int8_t)buf[3]; > are you sure this works correctly? […] To be fair, I just copy-pasted this line from the existing code. https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/src/osmo-bts-trx/trx_if.c@987 PS7, Line 987: loop: > do { I prefer to use 'goto' here to avoid wrapping large code blocks into { }, and see no problem with using it. https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/src/osmo-bts-trx/trx_if.c@1114 PS7, Line 1114: LOGPPHI(l1h->phy_inst, DTRX, LOGL_DEBUG, > not sure if we want to have this log here, looks really verbose. I am just moving the existing log line, not introducing a new one. Sometimes it's useful to see what [we think] we send, so let's keep it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23833 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3532a6693bb335043ec390049138308991083e66 Gerrit-Change-Number: 23833 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 30 Apr 2021 14:16:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210430/bb250f5a/attachment.htm>