<p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/23833">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/include/osmo-bts/scheduler.h">File include/osmo-bts/scheduler.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/include/osmo-bts/scheduler.h@256">Patch Set #7, Line 256:</a> <code style="font-family:monospace,monospace"> uint8_t _pdu_num; /*!< Number of this PDU within the datagram */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">you mean the PDU position?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This field basically holds the number of parsed PDUs, so when it's 0 we expect TDMA frame number to be present, otherwise it's absent.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/src/osmo-bts-trx/trx_if.c">File src/osmo-bts-trx/trx_if.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/src/osmo-bts-trx/trx_if.c@726">Patch Set #7, Line 726:</a> <code style="font-family:monospace,monospace">#define TRX_UL_V2HDR_LEN 1 + 1 + 1 + 1 + 2 + 2</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">missing ()</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/src/osmo-bts-trx/trx_if.c@852">Patch Set #7, Line 852:</a> <code style="font-family:monospace,monospace"> bi->rssi = -(int8_t)buf[3];</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">are you sure this works correctly? […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">To be fair, I just copy-pasted this line from the existing code.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/src/osmo-bts-trx/trx_if.c@987">Patch Set #7, Line 987:</a> <code style="font-family:monospace,monospace">loop:</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">do {</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I prefer to use 'goto' here to avoid wrapping large code blocks into { }, and see no problem with using it.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/23833/7/src/osmo-bts-trx/trx_if.c@1114">Patch Set #7, Line 1114:</a> <code style="font-family:monospace,monospace"> LOGPPHI(l1h->phy_inst, DTRX, LOGL_DEBUG,</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">not sure if we want to have this log here, looks really verbose.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I am just moving the existing log line, not introducing a new one. Sometimes it's useful to see what [we think] we send, so let's keep it.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/23833">change 23833</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/23833"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3532a6693bb335043ec390049138308991083e66 </div>
<div style="display:none"> Gerrit-Change-Number: 23833 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 30 Apr 2021 14:16:48 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>