This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/23977 ) Change subject: Fix ipa_ccm_make_id_resp_from_req ...................................................................... Fix ipa_ccm_make_id_resp_from_req In 2018, I4723361e1094b358310541a7dc4c5c921c778a15 introuced a check against an integer unterflow. However, the fheck got the logic wrong, with the result of breaking the function completely: It would always only detect the first tag within the IPA request and then take the branch that assumes an integer underflow. Change-Id: I344975d0bda565ff196a1c0c69305cd349b98a19 --- M src/gsm/ipa.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/77/23977/1 diff --git a/src/gsm/ipa.c b/src/gsm/ipa.c index 7a26ba4..fdc0bc6 100644 --- a/src/gsm/ipa.c +++ b/src/gsm/ipa.c @@ -427,9 +427,9 @@ /* prevent any unsigned integer underflow due to somebody sending us * messages with wrong length values */ if (len <= t_len) - len -= t_len; - else len = 0; + else + len -= t_len; } return ipa_ccm_make_id_resp(dev, ies, num_ies); } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23977 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I344975d0bda565ff196a1c0c69305cd349b98a19 Gerrit-Change-Number: 23977 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210429/23f31880/attachment.htm>