<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23977">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Fix ipa_ccm_make_id_resp_from_req<br><br>In 2018, I4723361e1094b358310541a7dc4c5c921c778a15 introuced a<br>check against an integer unterflow.  However, the fheck got the<br>logic wrong, with the result of breaking the function completely:<br>It would always only detect the first tag within the IPA request<br>and then take the branch that assumes an integer underflow.<br><br>Change-Id: I344975d0bda565ff196a1c0c69305cd349b98a19<br>---<br>M src/gsm/ipa.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/77/23977/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsm/ipa.c b/src/gsm/ipa.c</span><br><span>index 7a26ba4..fdc0bc6 100644</span><br><span>--- a/src/gsm/ipa.c</span><br><span>+++ b/src/gsm/ipa.c</span><br><span>@@ -427,9 +427,9 @@</span><br><span>                /* prevent any unsigned integer underflow due to somebody sending us</span><br><span>                  * messages with wrong length values */</span><br><span>              if (len <= t_len)</span><br><span style="color: hsl(0, 100%, 40%);">-                    len -= t_len;</span><br><span style="color: hsl(0, 100%, 40%);">-           else</span><br><span>                         len = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+              else</span><br><span style="color: hsl(120, 100%, 40%);">+                  len -= t_len;</span><br><span>        }</span><br><span>    return ipa_ccm_make_id_resp(dev, ies, num_ies);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/23977">change 23977</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/23977"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I344975d0bda565ff196a1c0c69305cd349b98a19 </div>
<div style="display:none"> Gerrit-Change-Number: 23977 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>