This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23774 ) Change subject: osmo-bts-trx: correct definition of 'osmotrx rx-gain' command ...................................................................... osmo-bts-trx: correct definition of 'osmotrx rx-gain' command * Calling l1if_provision_transceiver_trx() yelds nothing. * It does not apply immediately, full restart required. Change-Id: I93c9e19d0543f19528cec842b8be332b4d93214e --- M src/osmo-bts-trx/trx_vty.c 1 file changed, 6 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/osmo-bts-trx/trx_vty.c b/src/osmo-bts-trx/trx_vty.c index 8e701ea..4e8c8d6 100644 --- a/src/osmo-bts-trx/trx_vty.c +++ b/src/osmo-bts-trx/trx_vty.c @@ -357,12 +357,12 @@ return CMD_SUCCESS; } -DEFUN_ATTR(cfg_phyinst_rxgain, cfg_phyinst_rxgain_cmd, - "osmotrx rx-gain <0-50>", - OSMOTRX_STR - "Set the receiver gain in dB\n" - "Gain in dB\n", - CMD_ATTR_IMMEDIATE) +DEFUN_USRATTR(cfg_phyinst_rxgain, cfg_phyinst_rxgain_cmd, + X(BTS_VTY_TRX_POWERCYCLE), + "osmotrx rx-gain <0-50>", + OSMOTRX_STR + "Set the receiver gain in dB\n" + "Gain in dB\n") { struct phy_instance *pinst = vty->index; struct trx_l1h *l1h = pinst->u.osmotrx.hdl; @@ -370,7 +370,6 @@ l1h->config.rxgain = atoi(argv[0]); l1h->config.rxgain_valid = 1; l1h->config.rxgain_sent = false; - l1if_provision_transceiver_trx(l1h); return CMD_SUCCESS; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23774 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I93c9e19d0543f19528cec842b8be332b4d93214e Gerrit-Change-Number: 23774 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210416/49e99a2a/attachment.htm>