<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/23774">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  dexter: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo-bts-trx: correct definition of 'osmotrx rx-gain' command<br><br>* Calling l1if_provision_transceiver_trx() yelds nothing.<br>* It does not apply immediately, full restart required.<br><br>Change-Id: I93c9e19d0543f19528cec842b8be332b4d93214e<br>---<br>M src/osmo-bts-trx/trx_vty.c<br>1 file changed, 6 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/trx_vty.c b/src/osmo-bts-trx/trx_vty.c</span><br><span>index 8e701ea..4e8c8d6 100644</span><br><span>--- a/src/osmo-bts-trx/trx_vty.c</span><br><span>+++ b/src/osmo-bts-trx/trx_vty.c</span><br><span>@@ -357,12 +357,12 @@</span><br><span>        return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-DEFUN_ATTR(cfg_phyinst_rxgain, cfg_phyinst_rxgain_cmd,</span><br><span style="color: hsl(0, 100%, 40%);">-         "osmotrx rx-gain <0-50>",</span><br><span style="color: hsl(0, 100%, 40%);">-       OSMOTRX_STR</span><br><span style="color: hsl(0, 100%, 40%);">-     "Set the receiver gain in dB\n"</span><br><span style="color: hsl(0, 100%, 40%);">-       "Gain in dB\n",</span><br><span style="color: hsl(0, 100%, 40%);">-       CMD_ATTR_IMMEDIATE)</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN_USRATTR(cfg_phyinst_rxgain, cfg_phyinst_rxgain_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+           X(BTS_VTY_TRX_POWERCYCLE),</span><br><span style="color: hsl(120, 100%, 40%);">+            "osmotrx rx-gain <0-50>",</span><br><span style="color: hsl(120, 100%, 40%);">+             OSMOTRX_STR</span><br><span style="color: hsl(120, 100%, 40%);">+           "Set the receiver gain in dB\n"</span><br><span style="color: hsl(120, 100%, 40%);">+             "Gain in dB\n")</span><br><span> {</span><br><span>         struct phy_instance *pinst = vty->index;</span><br><span>  struct trx_l1h *l1h = pinst->u.osmotrx.hdl;</span><br><span>@@ -370,7 +370,6 @@</span><br><span>         l1h->config.rxgain = atoi(argv[0]);</span><br><span>       l1h->config.rxgain_valid = 1;</span><br><span>     l1h->config.rxgain_sent = false;</span><br><span style="color: hsl(0, 100%, 40%);">-     l1if_provision_transceiver_trx(l1h);</span><br><span> </span><br><span>     return CMD_SUCCESS;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/23774">change 23774</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/23774"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I93c9e19d0543f19528cec842b8be332b4d93214e </div>
<div style="display:none"> Gerrit-Change-Number: 23774 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>