This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23728 ) Change subject: deprecation: use osmo_bts_features_*() ...................................................................... deprecation: use osmo_bts_features_*() For "reported feature '%s'...", use the short feature name, which better matches the message. Change-Id: Ie09506fbf3a1f0e899f9f4c8070e3139fd1d5e9d --- M TODO-RELEASE M src/osmo-bsc/abis_nm.c M src/osmo-bsc/bsc_vty.c 3 files changed, 3 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index d0852fc..1a72401 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmocore >1.5.1 needs osmo_bts_features_name(), osmo_bts_features_desc() diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index 3eab14e..ba1075a 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -607,7 +607,7 @@ if (!Frep && Fexp) { LOGPMO(&bts->mo, DNM, LOGL_NOTICE, "Get Attributes Response: " "reported feature '%s' is not supported, while we thought it is.\n", - osmo_bts_feature_name(i)); + osmo_bts_features_name(i)); } } } diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index 57c1f0a..1d29f1b 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -349,7 +349,7 @@ for (i = 0; i < _NUM_BTS_FEAT; i++) { if (osmo_bts_has_feature(&bts->features, i)) { vty_out(vty, " %03u ", i); - vty_out(vty, "%-40s%s", osmo_bts_feature_name(i), VTY_NEWLINE); + vty_out(vty, "%-40s%s", osmo_bts_features_desc(i), VTY_NEWLINE); no_features = false; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie09506fbf3a1f0e899f9f4c8070e3139fd1d5e9d Gerrit-Change-Number: 23728 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210414/173074d8/attachment.htm>