<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23728">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">deprecation: use osmo_bts_features_*()<br><br>For "reported feature '%s'...", use the short feature name, which better<br>matches the message.<br><br>Change-Id: Ie09506fbf3a1f0e899f9f4c8070e3139fd1d5e9d<br>---<br>M TODO-RELEASE<br>M src/osmo-bsc/abis_nm.c<br>M src/osmo-bsc/bsc_vty.c<br>3 files changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/TODO-RELEASE b/TODO-RELEASE</span><br><span>index d0852fc..1a72401 100644</span><br><span>--- a/TODO-RELEASE</span><br><span>+++ b/TODO-RELEASE</span><br><span>@@ -7,3 +7,4 @@</span><br><span> # If any interfaces have been added since the last public release: c:r:a + 1.</span><br><span> # If any interfaces have been removed or changed since the last public release: c:r:0.</span><br><span> #library    what            description / commit summary line</span><br><span style="color: hsl(120, 100%, 40%);">+libosmocore  >1.5.1               needs osmo_bts_features_name(), osmo_bts_features_desc()</span><br><span>diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c</span><br><span>index 3eab14e..ba1075a 100644</span><br><span>--- a/src/osmo-bsc/abis_nm.c</span><br><span>+++ b/src/osmo-bsc/abis_nm.c</span><br><span>@@ -607,7 +607,7 @@</span><br><span>                  if (!Frep && Fexp) {</span><br><span>                                 LOGPMO(&bts->mo, DNM, LOGL_NOTICE, "Get Attributes Response: "</span><br><span>                                     "reported feature '%s' is not supported, while we thought it is.\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                                  osmo_bts_feature_name(i));</span><br><span style="color: hsl(120, 100%, 40%);">+                                    osmo_bts_features_name(i));</span><br><span>                   }</span><br><span>            }</span><br><span>    }</span><br><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index 57c1f0a..1d29f1b 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -349,7 +349,7 @@</span><br><span>         for (i = 0; i < _NUM_BTS_FEAT; i++) {</span><br><span>             if (osmo_bts_has_feature(&bts->features, i)) {</span><br><span>                        vty_out(vty, "    %03u ", i);</span><br><span style="color: hsl(0, 100%, 40%);">-                 vty_out(vty, "%-40s%s", osmo_bts_feature_name(i), VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+                     vty_out(vty, "%-40s%s", osmo_bts_features_desc(i), VTY_NEWLINE);</span><br><span>                   no_features = false;</span><br><span>                 }</span><br><span>    }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23728">change 23728</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/23728"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie09506fbf3a1f0e899f9f4c8070e3139fd1d5e9d </div>
<div style="display:none"> Gerrit-Change-Number: 23728 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>