This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orgHello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23623 to review the following change. Change subject: cardem: ignore set ATR ...................................................................... cardem: ignore set ATR the PPS procedure with baud rate change has not been tested. by keeping the default ATR instead of applying the ATR sent by the host software, no other baud rate choice is offered. Change-Id: Ibf7c6b83d2cf68172c7aa25116d838e24a95d5fe --- M firmware/libcommon/source/card_emu.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/23/23623/1 diff --git a/firmware/libcommon/source/card_emu.c b/firmware/libcommon/source/card_emu.c index 259d48e..f84f334 100644 --- a/firmware/libcommon/source/card_emu.c +++ b/firmware/libcommon/source/card_emu.c @@ -1238,17 +1238,20 @@ if (len > sizeof(ch->atr.atr)) return -1; +/* ignore new ATR for now since we PPS has not been tested memcpy(ch->atr.atr, atr, len); ch->atr.len = len; ch->atr.idx = 0; +*/ #if TRACE_LEVEL >= TRACE_LEVEL_INFO uint8_t i; TRACE_INFO("%u: ATR set: ", ch->num); - for (i = 0; i < ch->atr.len; i++) { + for (i = 0; i < len; i++) { TRACE_INFO_WP("%02x ", atr[i]); } TRACE_INFO_WP("\n\r"); + TRACE_INFO("%u: ATR set currently ignored\n\r", ch->num); #endif /* FIXME: race condition with transmitting ATR to reader? */ -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23623 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ibf7c6b83d2cf68172c7aa25116d838e24a95d5fe Gerrit-Change-Number: 23623 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: tsaitgaist <kredon at sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210404/a68bfc65/attachment.htm>