<p>laforge would like tsaitgaist to <strong>review</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/23623">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cardem: ignore set ATR<br><br>the PPS procedure with baud rate change has not been tested.<br>by keeping the default ATR instead of applying the ATR sent by<br>the host software, no other baud rate choice is offered.<br><br>Change-Id: Ibf7c6b83d2cf68172c7aa25116d838e24a95d5fe<br>---<br>M firmware/libcommon/source/card_emu.c<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/23/23623/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libcommon/source/card_emu.c b/firmware/libcommon/source/card_emu.c</span><br><span>index 259d48e..f84f334 100644</span><br><span>--- a/firmware/libcommon/source/card_emu.c</span><br><span>+++ b/firmware/libcommon/source/card_emu.c</span><br><span>@@ -1238,17 +1238,20 @@</span><br><span>    if (len > sizeof(ch->atr.atr))</span><br><span>                 return -1;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* ignore new ATR for now since we PPS has not been tested</span><br><span>   memcpy(ch->atr.atr, atr, len);</span><br><span>    ch->atr.len = len;</span><br><span>        ch->atr.idx = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+*/</span><br><span> </span><br><span> #if TRACE_LEVEL >= TRACE_LEVEL_INFO </span><br><span>       uint8_t i;</span><br><span>   TRACE_INFO("%u: ATR set: ", ch->num);</span><br><span style="color: hsl(0, 100%, 40%);">-      for (i = 0; i < ch->atr.len; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+     for (i = 0; i < len; i++) {</span><br><span>               TRACE_INFO_WP("%02x ", atr[i]);</span><br><span>    }</span><br><span>    TRACE_INFO_WP("\n\r");</span><br><span style="color: hsl(120, 100%, 40%);">+      TRACE_INFO("%u: ATR set currently ignored\n\r", ch->num);</span><br><span> #endif</span><br><span>     /* FIXME: race condition with transmitting ATR to reader? */</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/23623">change 23623</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/23623"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibf7c6b83d2cf68172c7aa25116d838e24a95d5fe </div>
<div style="display:none"> Gerrit-Change-Number: 23623 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: tsaitgaist <kredon@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: Jenkins Builder </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>