This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23593 ) Change subject: card_key_provider: Documentation with sphinx / autodoc ...................................................................... Patch Set 1: (4 comments) https://gerrit.osmocom.org/c/pysim/+/23593/1/pySim/card_key_provider.py File pySim/card_key_provider.py: https://gerrit.osmocom.org/c/pysim/+/23593/1/pySim/card_key_provider.py@38 PS1, Line 38: Abstract Unrelated: if it's an *abstract* class, why is it inherited from 'object' instead of 'abc.ABC'? Why do abstract methods lack '@abc.abstractmethod'? See https://docs.python.org/3/library/abc.html. https://gerrit.osmocom.org/c/pysim/+/23593/1/pySim/card_key_provider.py@94 PS1, Line 94: CSV file unrelated? https://gerrit.osmocom.org/c/pysim/+/23593/1/pySim/card_key_provider.py@143 PS1, Line 143: element unrelated? https://gerrit.osmocom.org/c/pysim/+/23593/1/pySim/card_key_provider.py@163 PS1, Line 163: element unrelated? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia41e14d643d452d92fc8d3c2fb9c4ac9021402e9 Gerrit-Change-Number: 23593 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Sat, 03 Apr 2021 23:04:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210403/9f33d833/attachment.htm>