<p><a href="https://gerrit.osmocom.org/c/pysim/+/23593">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/pysim/+/23593/1/pySim/card_key_provider.py">File pySim/card_key_provider.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/23593/1/pySim/card_key_provider.py@38">Patch Set #1, Line 38:</a> <code style="font-family:monospace,monospace">Abstract</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Unrelated: if it's an *abstract* class, why is it inherited from 'object' instead of 'abc.ABC'? Why do abstract methods lack '@abc.abstractmethod'? See https://docs.python.org/3/library/abc.html.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/23593/1/pySim/card_key_provider.py@94">Patch Set #1, Line 94:</a> <code style="font-family:monospace,monospace">CSV file</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">unrelated?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/23593/1/pySim/card_key_provider.py@143">Patch Set #1, Line 143:</a> <code style="font-family:monospace,monospace">element</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">unrelated?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/23593/1/pySim/card_key_provider.py@163">Patch Set #1, Line 163:</a> <code style="font-family:monospace,monospace">element</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">unrelated?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/23593">change 23593</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/23593"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia41e14d643d452d92fc8d3c2fb9c4ac9021402e9 </div>
<div style="display:none"> Gerrit-Change-Number: 23593 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 03 Apr 2021 23:04:16 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>