This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23564 )
Change subject: Add decoder/encoder for EF.SUCI_Calc_Info
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/pysim/+/23564/1/tests/test_utils.py
File tests/test_utils.py:
https://gerrit.osmocom.org/c/pysim/+/23564/1/tests/test_utils.py@95
PS1, Line 95: 0272DA71976234CE833A6907425867B82E074D44EF907DFB4B3E21C1C2256EBCD1
I would move this and the other key into separate [class] variables, so there would be no need to repeat it here and there:
HNET_PUBKEY27 = '...'
HNET_PUBKEY30 = '...'
FILE = '...' + HNET_PUBKEY27 + '...' + HNET_PUBKEY30
def testFoo(self):
...
def testBar(self):
...
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/23564
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I848a766e6d00be497c7db905475e0681cce197ac
Gerrit-Change-Number: 23564
Gerrit-PatchSet: 1
Gerrit-Owner: merlinchlosta <merlin.chlosta at rub.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Apr 2021 14:43:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210401/75c0c7a4/attachment.htm>