This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20324 ) Change subject: ipa oml: tx OPSTART after unlocking, not before ...................................................................... ipa oml: tx OPSTART after unlocking, not before According to TS 12.21, when adminsitratively Locking an object, in general it should go into operative state Disabled. We don't really implement it this way right now, but keep it this way consistent in all objects. Furthermore, TS 12.21. Figure 2 describes vaguely that unlock procedure is done around same time where object attributes are set, which is before OPSTART. Change-Id: Icd4b3bb467f23c9ddfa56f6b6f8a55da1e574ab8 --- M src/osmo-bsc/bts_ipaccess_nanobts.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/24/20324/1 diff --git a/src/osmo-bsc/bts_ipaccess_nanobts.c b/src/osmo-bsc/bts_ipaccess_nanobts.c index 796d208..e02eabc 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts.c @@ -211,12 +211,12 @@ 0, 0xff, msgb->data, msgb->len); msgb_free(msgb); - abis_nm_opstart(bts, obj_class, bts->bts_nr, - 0, 0xff); abis_nm_chg_adm_state(bts, obj_class, bts->bts_nr, 0, 0xff, NM_STATE_UNLOCKED); abis_nm_chg_adm_state(bts, NM_OC_GPRS_NSE, bts->bts_nr, 0xff, 0xff, NM_STATE_UNLOCKED); + abis_nm_opstart(bts, obj_class, bts->bts_nr, + 0, 0xff); } break; case NM_OC_GPRS_NSVC: @@ -234,11 +234,11 @@ nsvc->id, 0xff, msgb->data, msgb->len); msgb_free(msgb); - abis_nm_opstart(bts, obj_class, bts->bts_nr, - nsvc->id, 0xff); abis_nm_chg_adm_state(bts, obj_class, bts->bts_nr, nsvc->id, 0xff, NM_STATE_UNLOCKED); + abis_nm_opstart(bts, obj_class, bts->bts_nr, + nsvc->id, 0xff); } default: break; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icd4b3bb467f23c9ddfa56f6b6f8a55da1e574ab8 Gerrit-Change-Number: 20324 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200930/9166f2b9/attachment.htm>