<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20324">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ipa oml: tx OPSTART after unlocking, not before<br><br>According to TS 12.21, when adminsitratively Locking an object, in<br>general it should go into operative state Disabled. We don't really<br>implement it this way right now, but keep it this way consistent in all<br>objects.<br>Furthermore, TS 12.21. Figure 2 describes vaguely that unlock procedure<br>is done around same time where object attributes are set, which is<br>before OPSTART.<br><br>Change-Id: Icd4b3bb467f23c9ddfa56f6b6f8a55da1e574ab8<br>---<br>M src/osmo-bsc/bts_ipaccess_nanobts.c<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/24/20324/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bts_ipaccess_nanobts.c b/src/osmo-bsc/bts_ipaccess_nanobts.c</span><br><span>index 796d208..e02eabc 100644</span><br><span>--- a/src/osmo-bsc/bts_ipaccess_nanobts.c</span><br><span>+++ b/src/osmo-bsc/bts_ipaccess_nanobts.c</span><br><span>@@ -211,12 +211,12 @@</span><br><span>                                                0, 0xff, msgb->data,</span><br><span>                                              msgb->len);</span><br><span>                     msgb_free(msgb);</span><br><span style="color: hsl(0, 100%, 40%);">-                        abis_nm_opstart(bts, obj_class, bts->bts_nr,</span><br><span style="color: hsl(0, 100%, 40%);">-                                 0, 0xff);</span><br><span>                    abis_nm_chg_adm_state(bts, obj_class, bts->bts_nr,</span><br><span>                                              0, 0xff, NM_STATE_UNLOCKED);</span><br><span>                   abis_nm_chg_adm_state(bts, NM_OC_GPRS_NSE, bts->bts_nr,</span><br><span>                                         0xff, 0xff, NM_STATE_UNLOCKED);</span><br><span style="color: hsl(120, 100%, 40%);">+                 abis_nm_opstart(bts, obj_class, bts->bts_nr,</span><br><span style="color: hsl(120, 100%, 40%);">+                                       0, 0xff);</span><br><span>            }</span><br><span>            break;</span><br><span>       case NM_OC_GPRS_NSVC:</span><br><span>@@ -234,11 +234,11 @@</span><br><span>                                                  nsvc->id, 0xff,</span><br><span>                                                   msgb->data, msgb->len);</span><br><span>                      msgb_free(msgb);</span><br><span style="color: hsl(0, 100%, 40%);">-                        abis_nm_opstart(bts, obj_class, bts->bts_nr,</span><br><span style="color: hsl(0, 100%, 40%);">-                                 nsvc->id, 0xff);</span><br><span>                  abis_nm_chg_adm_state(bts, obj_class, bts->bts_nr,</span><br><span>                                              nsvc->id, 0xff,</span><br><span>                                           NM_STATE_UNLOCKED);</span><br><span style="color: hsl(120, 100%, 40%);">+                     abis_nm_opstart(bts, obj_class, bts->bts_nr,</span><br><span style="color: hsl(120, 100%, 40%);">+                                       nsvc->id, 0xff);</span><br><span>          }</span><br><span>    default:</span><br><span>             break;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20324">change 20324</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/20324"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icd4b3bb467f23c9ddfa56f6b6f8a55da1e574ab8 </div>
<div style="display:none"> Gerrit-Change-Number: 20324 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>