Change in osmo-bts[master]: vty: fix bts_dump_vty_features(): properly check BTS model flags

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Sep 25 18:25:29 UTC 2020


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/20285 )


Change subject: vty: fix bts_dump_vty_features(): properly check BTS model flags
......................................................................

vty: fix bts_dump_vty_features(): properly check BTS model flags

bts_internal_flag_get() expects a flag value, not an integer.

Change-Id: I88de79cc45fb64144df33b0ac3e3b91537039953
---
M src/common/vty.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/85/20285/1

diff --git a/src/common/vty.c b/src/common/vty.c
index d5993d6..36b0eaf 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -848,9 +848,9 @@
 	vty_out(vty, "  BTS model specific (internal) flags:%s", VTY_NEWLINE);
 
 	for (i = 0, no_features = true; i < sizeof(bts->flags) * 8; i++) {
-		if (bts_internal_flag_get(bts, i)) {
+		if (bts_internal_flag_get(bts, (1 << i))) {
 			vty_out(vty, "    %03u ", i);
-			vty_out(vty, "%-40s%s", get_value_string(bts_impl_flag_desc, i), VTY_NEWLINE);
+			vty_out(vty, "%-40s%s", get_value_string(bts_impl_flag_desc, (1 << i)), VTY_NEWLINE);
 			no_features = false;
 		}
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20285
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I88de79cc45fb64144df33b0ac3e3b91537039953
Gerrit-Change-Number: 20285
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200925/f162b653/attachment.htm>


More information about the gerrit-log mailing list