<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20285">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: fix bts_dump_vty_features(): properly check BTS model flags<br><br>bts_internal_flag_get() expects a flag value, not an integer.<br><br>Change-Id: I88de79cc45fb64144df33b0ac3e3b91537039953<br>---<br>M src/common/vty.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/85/20285/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/vty.c b/src/common/vty.c</span><br><span>index d5993d6..36b0eaf 100644</span><br><span>--- a/src/common/vty.c</span><br><span>+++ b/src/common/vty.c</span><br><span>@@ -848,9 +848,9 @@</span><br><span>    vty_out(vty, "  BTS model specific (internal) flags:%s", VTY_NEWLINE);</span><br><span> </span><br><span>         for (i = 0, no_features = true; i < sizeof(bts->flags) * 8; i++) {</span><br><span style="color: hsl(0, 100%, 40%);">-                if (bts_internal_flag_get(bts, i)) {</span><br><span style="color: hsl(120, 100%, 40%);">+          if (bts_internal_flag_get(bts, (1 << i))) {</span><br><span>                    vty_out(vty, "    %03u ", i);</span><br><span style="color: hsl(0, 100%, 40%);">-                 vty_out(vty, "%-40s%s", get_value_string(bts_impl_flag_desc, i), VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+                      vty_out(vty, "%-40s%s", get_value_string(bts_impl_flag_desc, (1 << i)), VTY_NEWLINE);</span><br><span>                        no_features = false;</span><br><span>                 }</span><br><span>    }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/20285">change 20285</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/20285"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I88de79cc45fb64144df33b0ac3e3b91537039953 </div>
<div style="display:none"> Gerrit-Change-Number: 20285 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>