Change in osmo-bsc[master]: abis_nm: abis_nm_perform_test: fix a potential null deref

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20233 )


Change subject: abis_nm: abis_nm_perform_test: fix a potential null deref
......................................................................

abis_nm: abis_nm_perform_test: fix a potential null deref

gcc 10.2.0 warns msgb can be a deref because nm_msgb_alloc() can fail with null.

Change-Id: I4b0e4cd15046272e026cd74c14cbf2972ef6a070
---
M src/osmo-bsc/abis_nm.c
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/33/20233/1

diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c
index ec52380..4691137 100644
--- a/src/osmo-bsc/abis_nm.c
+++ b/src/osmo-bsc/abis_nm.c
@@ -2193,8 +2193,11 @@
 
 	DEBUGP(DNM, "PERFORM TEST %s\n", abis_nm_test_name(test_nr));
 
-	if (!msg)
+	if (!msg) {
 		msg = nm_msgb_alloc();
+		if (!msg)
+			return -ENOMEM;
+	}
 
 	msgb_tv_push(msg, NM_ATT_AUTON_REPORT, auton_report);
 	msgb_tv_push(msg, NM_ATT_TEST_NO, test_nr);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20233
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I4b0e4cd15046272e026cd74c14cbf2972ef6a070
Gerrit-Change-Number: 20233
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200921/9c16fee1/attachment.htm>