<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20233">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">abis_nm: abis_nm_perform_test: fix a potential null deref<br><br>gcc 10.2.0 warns msgb can be a deref because nm_msgb_alloc() can fail with null.<br><br>Change-Id: I4b0e4cd15046272e026cd74c14cbf2972ef6a070<br>---<br>M src/osmo-bsc/abis_nm.c<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/33/20233/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c</span><br><span>index ec52380..4691137 100644</span><br><span>--- a/src/osmo-bsc/abis_nm.c</span><br><span>+++ b/src/osmo-bsc/abis_nm.c</span><br><span>@@ -2193,8 +2193,11 @@</span><br><span> </span><br><span>       DEBUGP(DNM, "PERFORM TEST %s\n", abis_nm_test_name(test_nr));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     if (!msg)</span><br><span style="color: hsl(120, 100%, 40%);">+     if (!msg) {</span><br><span>          msg = nm_msgb_alloc();</span><br><span style="color: hsl(120, 100%, 40%);">+                if (!msg)</span><br><span style="color: hsl(120, 100%, 40%);">+                     return -ENOMEM;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span> </span><br><span>        msgb_tv_push(msg, NM_ATT_AUTON_REPORT, auton_report);</span><br><span>        msgb_tv_push(msg, NM_ATT_TEST_NO, test_nr);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20233">change 20233</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/20233"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4b0e4cd15046272e026cd74c14cbf2972ef6a070 </div>
<div style="display:none"> Gerrit-Change-Number: 20233 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>