Change in pysim[master]: Remove redundant hexstr_to_fivebytearr() and hexstr_to_threebytearr()...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Sep 20 09:49:23 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/20196 )

Change subject: Remove redundant hexstr_to_fivebytearr() and hexstr_to_threebytearr() functions
......................................................................

Remove redundant hexstr_to_fivebytearr() and hexstr_to_threebytearr() functions

These functions are replaced by a more generic function hexstr_to_Nbytearr().
And, all occurances of redundant functions are replaced by generic functions
so its safe to remove them.

Change-Id: I7848451b90b35dca29d29f630cdc5405b5e9c19b
---
M pySim/utils.py
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/pySim/utils.py b/pySim/utils.py
index 43e4c53..c5cf480 100644
--- a/pySim/utils.py
+++ b/pySim/utils.py
@@ -122,12 +122,6 @@
 	if oplmn_disp: byte1 = byte1|0x02
 	return i2h([byte1])+s2h(name)
 
-def hexstr_to_fivebytearr(s):
-	return [s[i:i+10] for i in range(0, len(s), 10) ]
-
-def hexstr_to_threebytearr(s):
-	return [s[i:i+6] for i in range(0, len(s), 6) ]
-
 def hexstr_to_Nbytearr(s, nbytes):
 	return [s[i:i+(nbytes*2)] for i in range(0, len(s), (nbytes*2)) ]
 

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/20196
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7848451b90b35dca29d29f630cdc5405b5e9c19b
Gerrit-Change-Number: 20196
Gerrit-PatchSet: 2
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200920/0f295dff/attachment.htm>


More information about the gerrit-log mailing list