<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/20196">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Remove redundant hexstr_to_fivebytearr() and hexstr_to_threebytearr() functions<br><br>These functions are replaced by a more generic function hexstr_to_Nbytearr().<br>And, all occurances of redundant functions are replaced by generic functions<br>so its safe to remove them.<br><br>Change-Id: I7848451b90b35dca29d29f630cdc5405b5e9c19b<br>---<br>M pySim/utils.py<br>1 file changed, 0 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/utils.py b/pySim/utils.py</span><br><span>index 43e4c53..c5cf480 100644</span><br><span>--- a/pySim/utils.py</span><br><span>+++ b/pySim/utils.py</span><br><span>@@ -122,12 +122,6 @@</span><br><span>     if oplmn_disp: byte1 = byte1|0x02</span><br><span>    return i2h([byte1])+s2h(name)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-def hexstr_to_fivebytearr(s):</span><br><span style="color: hsl(0, 100%, 40%);">-  return [s[i:i+10] for i in range(0, len(s), 10) ]</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-def hexstr_to_threebytearr(s):</span><br><span style="color: hsl(0, 100%, 40%);">- return [s[i:i+6] for i in range(0, len(s), 6) ]</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> def hexstr_to_Nbytearr(s, nbytes):</span><br><span>        return [s[i:i+(nbytes*2)] for i in range(0, len(s), (nbytes*2)) ]</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/20196">change 20196</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/20196"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7848451b90b35dca29d29f630cdc5405b5e9c19b </div>
<div style="display:none"> Gerrit-Change-Number: 20196 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>