This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/20018 ) Change subject: ipa_proto: Implement ccm response with variable options ...................................................................... Patch Set 2: Code-Review+1 (1 comment) > Thank you for the review! Thanks for your contributions ;) https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/20018/1/src/ipa_proto.erl File src/ipa_proto.erl: https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/20018/1/src/ipa_proto.erl@97 PS1, Line 97: set_ccm_options Oh, you're right, I didn't notice that 'export_all'. It looks like a debugging leftover, and should be removed / commented out some day. So I would still expose this API explicitly. > ... others were not explicitly exported either. Actually, register_stream() ... controlling_process() are exposed. I am not going to block your work though, this can be merged as-is. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/20018 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_ss7 Gerrit-Branch: master Gerrit-Change-Id: I3f67095f33f1ff826ad04dad72990bf79617149a Gerrit-Change-Number: 20018 Gerrit-PatchSet: 2 Gerrit-Owner: matt9j <matt9j at cs.washington.edu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: matt9j <matt9j at cs.washington.edu> Gerrit-Comment-Date: Sat, 12 Sep 2020 07:03:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Comment-In-Reply-To: matt9j <matt9j at cs.washington.edu> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200912/c8a6392b/attachment.htm>