<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Thank you for the review!</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Thanks for your contributions ;)</p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/20018">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/20018/1/src/ipa_proto.erl">File src/ipa_proto.erl:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/20018/1/src/ipa_proto.erl@97">Patch Set #1, Line 97:</a> <code style="font-family:monospace,monospace">set_ccm_options</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Oh, you're right, I didn't notice that 'export_all'. It looks like a debugging leftover, and should be removed / commented out some day. So I would still expose this API explicitly.</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">... others were not explicitly exported either.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Actually, register_stream() ... controlling_process() are exposed.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I am not going to block your work though, this can be merged as-is.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/20018">change 20018</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/20018"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: erlang/osmo_ss7 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3f67095f33f1ff826ad04dad72990bf79617149a </div>
<div style="display:none"> Gerrit-Change-Number: 20018 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: matt9j <matt9j@cs.washington.edu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: matt9j <matt9j@cs.washington.edu> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 12 Sep 2020 07:03:37 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Comment-In-Reply-To: matt9j <matt9j@cs.washington.edu> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>