Change in pysim[master]: Use the function select_adf_by_aid for selecting an AID

[herlesupreeth]

herlesupreeth has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/20095 )


Change subject: Use the function select_adf_by_aid for selecting an AID
......................................................................

Use the function select_adf_by_aid for selecting an AID

Basically, the idea is to read all the AIDs on the UICC once
rather than reading each time we want to select an ADF.

The function select_adf_by_aid select the ADF by its AID which
is already populated by read_aids() function

Change-Id: I5e0e87e9cf238922d60fda7a7836e65f91f2c233
---
M pySim/cards.py
1 file changed, 2 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/95/20095/1

diff --git a/pySim/cards.py b/pySim/cards.py
index 76d405b..d1b449a 100644
--- a/pySim/cards.py
+++ b/pySim/cards.py
@@ -1165,20 +1165,14 @@
 			self._scc.update_binary('6f20', p['opc'], 17)
 
 		# update EF-USIM_AUTH_KEY in ADF.ISIM
-		self._scc.select_file(['3f00'])
-		aid = self.read_aid(isim = True)
-		if (aid):
-			self._scc.select_adf(aid)
+		if '9000' == self.select_adf_by_aid(adf="isim"):
 			if p.get('ki'):
 				self._scc.update_binary('af20', p['ki'], 1)
 			if p.get('opc'):
 				self._scc.update_binary('af20', p['opc'], 17)
 
-		self._scc.select_file(['3f00'])
-		aid = self.read_aid()
-		if (aid):
+		if '9000' == self.select_adf_by_aid():
 			# update EF-USIM_AUTH_KEY in ADF.USIM
-			self._scc.select_adf(aid)
 			if p.get('ki'):
 				self._scc.update_binary('af20', p['ki'], 1)
 			if p.get('opc'):

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/20095
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I5e0e87e9cf238922d60fda7a7836e65f91f2c233
Gerrit-Change-Number: 20095
Gerrit-PatchSet: 1
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200911/6c377c1c/attachment.htm>