<p>herlesupreeth has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/20095">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Use the function select_adf_by_aid for selecting an AID<br><br>Basically, the idea is to read all the AIDs on the UICC once<br>rather than reading each time we want to select an ADF.<br><br>The function select_adf_by_aid select the ADF by its AID which<br>is already populated by read_aids() function<br><br>Change-Id: I5e0e87e9cf238922d60fda7a7836e65f91f2c233<br>---<br>M pySim/cards.py<br>1 file changed, 2 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/95/20095/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/cards.py b/pySim/cards.py</span><br><span>index 76d405b..d1b449a 100644</span><br><span>--- a/pySim/cards.py</span><br><span>+++ b/pySim/cards.py</span><br><span>@@ -1165,20 +1165,14 @@</span><br><span>                   self._scc.update_binary('6f20', p['opc'], 17)</span><br><span> </span><br><span>            # update EF-USIM_AUTH_KEY in ADF.ISIM</span><br><span style="color: hsl(0, 100%, 40%);">-           self._scc.select_file(['3f00'])</span><br><span style="color: hsl(0, 100%, 40%);">-         aid = self.read_aid(isim = True)</span><br><span style="color: hsl(0, 100%, 40%);">-                if (aid):</span><br><span style="color: hsl(0, 100%, 40%);">-                       self._scc.select_adf(aid)</span><br><span style="color: hsl(120, 100%, 40%);">+             if '9000' == self.select_adf_by_aid(adf="isim"):</span><br><span>                   if p.get('ki'):</span><br><span>                              self._scc.update_binary('af20', p['ki'], 1)</span><br><span>                  if p.get('opc'):</span><br><span>                             self._scc.update_binary('af20', p['opc'], 17)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-               self._scc.select_file(['3f00'])</span><br><span style="color: hsl(0, 100%, 40%);">-         aid = self.read_aid()</span><br><span style="color: hsl(0, 100%, 40%);">-           if (aid):</span><br><span style="color: hsl(120, 100%, 40%);">+             if '9000' == self.select_adf_by_aid():</span><br><span>                       # update EF-USIM_AUTH_KEY in ADF.USIM</span><br><span style="color: hsl(0, 100%, 40%);">-                   self._scc.select_adf(aid)</span><br><span>                    if p.get('ki'):</span><br><span>                              self._scc.update_binary('af20', p['ki'], 1)</span><br><span>                  if p.get('opc'):</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/20095">change 20095</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/20095"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5e0e87e9cf238922d60fda7a7836e65f91f2c233 </div>
<div style="display:none"> Gerrit-Change-Number: 20095 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>