Change in osmo-bsc[master]: abis_rsl: inform user when expired channel requests get tossed

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Sep 11 13:01:51 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20067 )

Change subject: abis_rsl: inform user when expired channel requests get tossed
......................................................................

abis_rsl: inform user when expired channel requests get tossed

At the moment expired channel requests are dropped silently, however, it
might help to know when this happens - not only for debugging.

Change-Id: Ib49df551a4cd7d5652e85c8ce29ef132385d4ae4
Related: OS#4549
---
M src/osmo-bsc/abis_rsl.c
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index c0907c0..347be12 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -1384,10 +1384,14 @@
 	llist_for_each_entry_safe(rqd, rqd_tmp, &bts->chan_rqd_queue, entry) {
 		/* If the channel request is older than the radio link timeout we drop it. This also means that the
 		 * queue is under its overflow limit again. */
-		if (timestamp_current - rqd->timestamp > rlt)
+		if (timestamp_current - rqd->timestamp > rlt) {
+			LOG_BTS(bts, DRSL, LOGL_INFO, "CHAN RQD: tossing expired channel request"
+				"(ra=0x%02x, neci=0x%02x, chreq_reason=0x%02x)\n",
+				rqd->ref.ra, bts->network->neci, rqd->reason);
 			llist_del(&rqd->entry);
-		else
+		} else {
 			rqd_count++;
+		}
 	}
 
 	/* If we find more than 255 (256) unexpired channel requests in the queue it is very likely that there is a

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20067
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib49df551a4cd7d5652e85c8ce29ef132385d4ae4
Gerrit-Change-Number: 20067
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200911/4e1e9923/attachment.htm>


More information about the gerrit-log mailing list