<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20067">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">abis_rsl: inform user when expired channel requests get tossed<br><br>At the moment expired channel requests are dropped silently, however, it<br>might help to know when this happens - not only for debugging.<br><br>Change-Id: Ib49df551a4cd7d5652e85c8ce29ef132385d4ae4<br>Related: OS#4549<br>---<br>M src/osmo-bsc/abis_rsl.c<br>1 file changed, 6 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c</span><br><span>index c0907c0..347be12 100644</span><br><span>--- a/src/osmo-bsc/abis_rsl.c</span><br><span>+++ b/src/osmo-bsc/abis_rsl.c</span><br><span>@@ -1384,10 +1384,14 @@</span><br><span>    llist_for_each_entry_safe(rqd, rqd_tmp, &bts->chan_rqd_queue, entry) {</span><br><span>                /* If the channel request is older than the radio link timeout we drop it. This also means that the</span><br><span>           * queue is under its overflow limit again. */</span><br><span style="color: hsl(0, 100%, 40%);">-          if (timestamp_current - rqd->timestamp > rlt)</span><br><span style="color: hsl(120, 100%, 40%);">+           if (timestamp_current - rqd->timestamp > rlt) {</span><br><span style="color: hsl(120, 100%, 40%);">+                 LOG_BTS(bts, DRSL, LOGL_INFO, "CHAN RQD: tossing expired channel request"</span><br><span style="color: hsl(120, 100%, 40%);">+                           "(ra=0x%02x, neci=0x%02x, chreq_reason=0x%02x)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                          rqd->ref.ra, bts->network->neci, rqd->reason);</span><br><span>                   llist_del(&rqd->entry);</span><br><span style="color: hsl(0, 100%, 40%);">-          else</span><br><span style="color: hsl(120, 100%, 40%);">+          } else {</span><br><span>                     rqd_count++;</span><br><span style="color: hsl(120, 100%, 40%);">+          }</span><br><span>    }</span><br><span> </span><br><span>        /* If we find more than 255 (256) unexpired channel requests in the queue it is very likely that there is a</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20067">change 20067</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/20067"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib49df551a4cd7d5652e85c8ce29ef132385d4ae4 </div>
<div style="display:none"> Gerrit-Change-Number: 20067 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>