This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
lynxis lazus gerrit-no-reply at lists.osmocom.orglynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20057 ) Change subject: gsm_data: always set spare bits in channel description ...................................................................... gsm_data: always set spare bits in channel description The spare bits were never encoded even when the spec says it must be 00. Most caller of _chan_desc_fill_tail() initialized the struct with memset(), but not all. The SI4 did not initialized it. Change-Id: Ib03d6d2cdadc49e49aa94917d17f81ef3c83f11c --- M src/osmo-bsc/gsm_data.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/57/20057/1 diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c index c0c8cf6..fbc2ae2 100644 --- a/src/osmo-bsc/gsm_data.c +++ b/src/osmo-bsc/gsm_data.c @@ -601,6 +601,7 @@ uint16_t arfcn = lchan->ts->trx->arfcn & 0x3ff; cd->h0.tsc = gsm_ts_tsc(lchan->ts); cd->h0.h = 0; + cd->h0.spare = 0; cd->h0.arfcn_high = arfcn >> 8; cd->h0.arfcn_low = arfcn & 0xff; } else { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20057 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib03d6d2cdadc49e49aa94917d17f81ef3c83f11c Gerrit-Change-Number: 20057 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200909/678249d2/attachment.htm>