<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20057">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm_data: always set spare bits in channel description<br><br>The spare bits were never encoded even when the spec says it must be 00.<br>Most caller of _chan_desc_fill_tail() initialized the struct with memset(),<br>but not all.<br>The SI4 did not initialized it.<br><br>Change-Id: Ib03d6d2cdadc49e49aa94917d17f81ef3c83f11c<br>---<br>M src/osmo-bsc/gsm_data.c<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/57/20057/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c</span><br><span>index c0c8cf6..fbc2ae2 100644</span><br><span>--- a/src/osmo-bsc/gsm_data.c</span><br><span>+++ b/src/osmo-bsc/gsm_data.c</span><br><span>@@ -601,6 +601,7 @@</span><br><span>                uint16_t arfcn = lchan->ts->trx->arfcn & 0x3ff;</span><br><span>                 cd->h0.tsc = gsm_ts_tsc(lchan->ts);</span><br><span>            cd->h0.h = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+              cd->h0.spare = 0;</span><br><span>                 cd->h0.arfcn_high = arfcn >> 8;</span><br><span>             cd->h0.arfcn_low = arfcn & 0xff;</span><br><span>      } else {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20057">change 20057</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/20057"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib03d6d2cdadc49e49aa94917d17f81ef3c83f11c </div>
<div style="display:none"> Gerrit-Change-Number: 20057 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>