Change in osmo-bsc[master]: fix bootstrap_rsl(): check result of gsm_bts_trx_set_system_infos()

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19964 )

Change subject: fix bootstrap_rsl(): check result of gsm_bts_trx_set_system_infos()
......................................................................

fix bootstrap_rsl(): check result of gsm_bts_trx_set_system_infos()

Ensure that osmo-bsc would not continue to work as usual, if for
some reason we cannot encode or send System Information messages.

Change-Id: I7d3458fb10760e33411f2074a6b2df1c257438d5
---
M src/osmo-bsc/osmo_bsc_main.c
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c
index ebae0a2..560f8fd 100644
--- a/src/osmo-bsc/osmo_bsc_main.c
+++ b/src/osmo-bsc/osmo_bsc_main.c
@@ -308,7 +308,10 @@
 	if (trx_is_usable(trx))
 		acc_ramp_trigger(&trx->bts->acc_ramp);
 
-	gsm_bts_trx_set_system_infos(trx);
+	if (gsm_bts_trx_set_system_infos(trx) != 0) {
+		LOG_TRX(trx, DRSL, LOGL_ERROR, "Failed to generate System Information\n");
+		return;
+	}
 
 	if (trx->bts->type == GSM_BTS_TYPE_NOKIA_SITE) {
 		/* channel unspecific, power reduction in 2 dB steps */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19964
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7d3458fb10760e33411f2074a6b2df1c257438d5
Gerrit-Change-Number: 19964
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200908/d0438716/attachment.htm>