<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19964">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix bootstrap_rsl(): check result of gsm_bts_trx_set_system_infos()<br><br>Ensure that osmo-bsc would not continue to work as usual, if for<br>some reason we cannot encode or send System Information messages.<br><br>Change-Id: I7d3458fb10760e33411f2074a6b2df1c257438d5<br>---<br>M src/osmo-bsc/osmo_bsc_main.c<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c</span><br><span>index ebae0a2..560f8fd 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_main.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_main.c</span><br><span>@@ -308,7 +308,10 @@</span><br><span>         if (trx_is_usable(trx))</span><br><span>              acc_ramp_trigger(&trx->bts->acc_ramp);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    gsm_bts_trx_set_system_infos(trx);</span><br><span style="color: hsl(120, 100%, 40%);">+    if (gsm_bts_trx_set_system_infos(trx) != 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+         LOG_TRX(trx, DRSL, LOGL_ERROR, "Failed to generate System Information\n");</span><br><span style="color: hsl(120, 100%, 40%);">+          return;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span> </span><br><span>        if (trx->bts->type == GSM_BTS_TYPE_NOKIA_SITE) {</span><br><span>               /* channel unspecific, power reduction in 2 dB steps */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19964">change 19964</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19964"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7d3458fb10760e33411f2074a6b2df1c257438d5 </div>
<div style="display:none"> Gerrit-Change-Number: 19964 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>