Change in osmo-pcu[master]: encoding: clarify docstring for write_packet_downlink_assignment()

[fixeria]

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20014 )

Change subject: encoding: clarify docstring for write_packet_downlink_assignment()
......................................................................

encoding: clarify docstring for write_packet_downlink_assignment()

Change-Id: I7c4458c2e7767b6cf03462ba79acdd9c9904ee83
---
M src/encoding.cpp
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/encoding.cpp b/src/encoding.cpp
index 76a1cec..2cee251 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -628,15 +628,14 @@
 }
 
 
-/* generate downlink assignment */
+/* Generate Packet Downlink Assignment as per 3GPP TS 44.060, section 11.2.7.
+ * NOTE: 'block' is expected to be zero-initialized by the caller. */
 void Encoding::write_packet_downlink_assignment(RlcMacDownlink_t * block,
 	bool old_tfi_is_valid, uint8_t old_tfi, uint8_t old_downlink,
 	const struct gprs_rlcmac_dl_tbf *tbf, uint8_t poll, uint8_t rrbp,
 	uint8_t alpha, uint8_t gamma, int8_t ta_idx,
 	uint8_t ta_ts, bool use_egprs)
 {
-	// Packet downlink assignment TS 44.060 11.2.7
-
 	PDA_AdditionsR99_t *pda_r99;
 
 	uint8_t tn;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20014
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I7c4458c2e7767b6cf03462ba79acdd9c9904ee83
Gerrit-Change-Number: 20014
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200908/db32a469/attachment.htm>