Change in osmo-ttcn3-hacks[master]: library/BSSAP_LE_Types: fix wrong field order in PDU_BSSAP_LE

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Sep 8 07:21:38 UTC 2020


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20015 )


Change subject: library/BSSAP_LE_Types: fix wrong field order in PDU_BSSAP_LE
......................................................................

library/BSSAP_LE_Types: fix wrong field order in PDU_BSSAP_LE

We use MSB ordering in this file:

  } with { encode "RAW" ; variant "FIELDORDER(msb)" }

but both fields were placed in LSB order.

See 3GPP TS 49.031, figure 8.3.6-1 for more details.

Change-Id: Ie9bbf99df0b189846c8ea3159bfd3c9a0ee5df2a
Related: OS#4597
---
M library/BSSAP_LE_Types.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/15/20015/1

diff --git a/library/BSSAP_LE_Types.ttcn b/library/BSSAP_LE_Types.ttcn
index ae7385b..9bfedc0 100644
--- a/library/BSSAP_LE_Types.ttcn
+++ b/library/BSSAP_LE_Types.ttcn
@@ -572,8 +572,8 @@
 }
 
 type record PDU_BSSAP_LE {
-	BIT1		discriminator, 	// 0 = BSSMAP-LE; 1 = DTAP-LE
 	BIT7		spare,		// always '0000000'B
+	BIT1		discriminator, 	// 0 = BSSMAP-LE; 1 = DTAP-LE
 	OCT1		dlci optional,
 	LIN1		lengthIndicator,
 	BSSMAPLEorDTAP	pdu

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20015
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie9bbf99df0b189846c8ea3159bfd3c9a0ee5df2a
Gerrit-Change-Number: 20015
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200908/4efce379/attachment.htm>


More information about the gerrit-log mailing list