Change in libosmocore[master]: Gb: add a second NS implementation

[lynxis lazus]

lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19417 )

Change subject: Gb: add a second NS implementation
......................................................................


Patch Set 22:

(3 comments)

https://gerrit.osmocom.org/c/libosmocore/+/19417/22/include/osmocom/gprs/gprs_ns2.h 
File include/osmocom/gprs/gprs_ns2.h:

https://gerrit.osmocom.org/c/libosmocore/+/19417/22/include/osmocom/gprs/gprs_ns2.h@25 
PS22, Line 25: enum gprs_ns2_signal_ns {
             : 	S_NSVC_RESET, /* when a NSVC is in reset */
             : 	S_NSVC_BLOCK, /* when a NSVC become blocked */
             : 	S_NSVC_UNBLOCK, /* when a NSVC become unblocked */
             : 	S_NSVC_ALIVE_EXP, /* Tns-alive expired more than N times */
             : 	S_NSVC_REPLACED, /* nsvc object is replaced (sets old_nsvc) */
             : 	S_NSVC_MISMATCH, /* got an unexpected IE (sets msg, pdu_type, ie_type) */
             : 	S_NSVC_DELETED, /* when a NSVC gets deleted */
             : 	S_SNS_CONFIGURED, /* IP-SNS configuration completed */
             : 	S_NSE_AVAILABLE, /* NSE is available */
             : 	S_NSE_UNAVAILABLE, /* NSE is unavailable */
             : };
             : 
             : struct gprs_ns2_signal_data {
             : 	struct gprs_ns2_nse *nse;
             : 	uint16_t nsei;
             : 	struct gprs_ns2_vc *nsvc;
             : 	struct gprs_ns2_vc *old_nsvc;
             : 	uint8_t cause;
             : 	uint8_t pdu_type;
             : 	uint8_t ie_type;
             : 	struct msgb *msg;
             : };
             : 
             : enum gprs_ns2_vc_mode {
             : 	NS2_VC_MODE_ALIVE, /* The VC will use RESET/BLOCK/UNBLOCK to start the connection and do ALIVE/ACK */
             : 	NS2_VC_MODE_BLOCKRESET, /* The will only use ALIVE/ACK no initiation */
             : };
             : 
             : /*! Osmoco NS events */
             : enum gprs_ns2_evt {
             : 	GPRS_NS_EVT_UNIT_DATA,
             : };
             : 
             : /* callbacks for messages transfer */
             : /*! Osmocom GPRS callback function type */
             : typedef int gprs_ns2_cb_t(enum gprs_ns2_evt event, struct msgb *msg,
             : 			  uint16_t nsei, uint16_t bvci);
> I know this patch has been very long in the pipeline already. […]
I agree. I wasn't sure if it would be good to add even more time into it.


https://gerrit.osmocom.org/c/libosmocore/+/19417/22/include/osmocom/gprs/gprs_ns2.h@86 
PS22, Line 86: int gprs_ns2_tx_block(struct gprs_ns2_vc *nsvc, uint8_t cause);
             : int gprs_ns2_tx_block_ack(struct gprs_ns2_vc *nsvc);
             : 
             : int gprs_ns2_tx_reset(struct gprs_ns2_vc *nsvc, uint8_t cause);
             : int gprs_ns2_tx_reset_ack(struct gprs_ns2_vc *nsvc);
             : 
             : int gprs_ns2_tx_unblock(struct gprs_ns2_vc *nsvc);
             : int gprs_ns2_tx_unblock_ack(struct gprs_ns2_vc *nsvc);
             : 
             : int gprs_ns2_tx_alive(struct gprs_ns2_vc *nsvc);
             : int gprs_ns2_tx_alive_ack(struct gprs_ns2_vc *nsvc);
> I think those low-level functions may not actually need to be exposed. […]
Ack


https://gerrit.osmocom.org/c/libosmocore/+/19417/22/include/osmocom/gprs/gprs_ns2.h@104 
PS22, Line 104: nt gprs_ns2_tx_sns_ack(struct gprs_ns2_vc *nsvc, uint8_t trans_id, uint8_t *cause,
              : 			const struct gprs_ns_ie_ip4_elem *ip4_elems,
              : 			unsigned int num_ip4_elems,
              : 			const struct gprs_ns_ie_ip6_elem *ip6_elems,
              : 			unsigned int num_ip6_elems);
              : int gprs_ns2_tx_sns_config(struct gprs_ns2_vc *nsvc, bool end_flag,
              : 			   const struct gprs_ns_ie_ip4_elem *ip4_elems,
              : 			   unsigned int num_ip4_elems,
              : 			   const struct gprs_ns_ie_ip6_elem *ip6_elems,
              : 			   unsigned int num_ip6_elems);
              : int gprs_ns2_tx_sns_config_ack(struct gprs_ns2_vc *nsvc, uint8_t *cause);
              : int gprs_ns2_tx_sns_size(struct gprs_ns2_vc *nsvc, bool reset_flag, uint16_t max_nr_nsvc,
              : 			 int ip4_ep_nr, int ip6_ep_nr);
              : int gprs_ns2_tx_sns_size_ack(struct gprs_ns2_vc *nsvc, uint8_t *cause);
> likewise all of those above. Those should be internal low-level functions inside the NS stack. […]
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19417
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3525beef205588dfab9d3880a34115f1a2676e48
Gerrit-Change-Number: 19417
Gerrit-PatchSet: 22
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Assignee: daniel <daniel at totalueberwachung.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-CC: daniel <daniel at totalueberwachung.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Sep 2020 14:31:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200907/f732f292/attachment.htm>