<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19417">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19417/22/include/osmocom/gprs/gprs_ns2.h">File include/osmocom/gprs/gprs_ns2.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/19417/22/include/osmocom/gprs/gprs_ns2.h@25">Patch Set #22, Line 25:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">enum gprs_ns2_signal_ns {<br> S_NSVC_RESET, /* when a NSVC is in reset */<br> S_NSVC_BLOCK, /* when a NSVC become blocked */<br> S_NSVC_UNBLOCK, /* when a NSVC become unblocked */<br> S_NSVC_ALIVE_EXP, /* Tns-alive expired more than N times */<br> S_NSVC_REPLACED, /* nsvc object is replaced (sets old_nsvc) */<br> S_NSVC_MISMATCH, /* got an unexpected IE (sets msg, pdu_type, ie_type) */<br> S_NSVC_DELETED, /* when a NSVC gets deleted */<br> S_SNS_CONFIGURED, /* IP-SNS configuration completed */<br> S_NSE_AVAILABLE, /* NSE is available */<br> S_NSE_UNAVAILABLE, /* NSE is unavailable */<br>};<br><br>struct gprs_ns2_signal_data {<br> struct gprs_ns2_nse *nse;<br> uint16_t nsei;<br> struct gprs_ns2_vc *nsvc;<br> struct gprs_ns2_vc *old_nsvc;<br> uint8_t cause;<br> uint8_t pdu_type;<br> uint8_t ie_type;<br> struct msgb *msg;<br>};<br><br>enum gprs_ns2_vc_mode {<br> NS2_VC_MODE_ALIVE, /* The VC will use RESET/BLOCK/UNBLOCK to start the connection and do ALIVE/ACK */<br> NS2_VC_MODE_BLOCKRESET, /* The will only use ALIVE/ACK no initiation */<br>};<br><br>/*! Osmoco NS events */<br>enum gprs_ns2_evt {<br> GPRS_NS_EVT_UNIT_DATA,<br>};<br><br>/* callbacks for messages transfer */<br>/*! Osmocom GPRS callback function type */<br>typedef int gprs_ns2_cb_t(enum gprs_ns2_evt event, struct msgb *msg,<br> uint16_t nsei, uint16_t bvci);<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I know this patch has been very long in the pipeline already. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I agree. I wasn't sure if it would be good to add even more time into it.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/19417/22/include/osmocom/gprs/gprs_ns2.h@86">Patch Set #22, Line 86:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">int gprs_ns2_tx_block(struct gprs_ns2_vc *nsvc, uint8_t cause);<br>int gprs_ns2_tx_block_ack(struct gprs_ns2_vc *nsvc);<br><br>int gprs_ns2_tx_reset(struct gprs_ns2_vc *nsvc, uint8_t cause);<br>int gprs_ns2_tx_reset_ack(struct gprs_ns2_vc *nsvc);<br><br>int gprs_ns2_tx_unblock(struct gprs_ns2_vc *nsvc);<br>int gprs_ns2_tx_unblock_ack(struct gprs_ns2_vc *nsvc);<br><br>int gprs_ns2_tx_alive(struct gprs_ns2_vc *nsvc);<br>int gprs_ns2_tx_alive_ack(struct gprs_ns2_vc *nsvc);<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I think those low-level functions may not actually need to be exposed. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/19417/22/include/osmocom/gprs/gprs_ns2.h@104">Patch Set #22, Line 104:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nt gprs_ns2_tx_sns_ack(struct gprs_ns2_vc *nsvc, uint8_t trans_id, uint8_t *cause,<br> const struct gprs_ns_ie_ip4_elem *ip4_elems,<br> unsigned int num_ip4_elems,<br> const struct gprs_ns_ie_ip6_elem *ip6_elems,<br> unsigned int num_ip6_elems);<br>int gprs_ns2_tx_sns_config(struct gprs_ns2_vc *nsvc, bool end_flag,<br> const struct gprs_ns_ie_ip4_elem *ip4_elems,<br> unsigned int num_ip4_elems,<br> const struct gprs_ns_ie_ip6_elem *ip6_elems,<br> unsigned int num_ip6_elems);<br>int gprs_ns2_tx_sns_config_ack(struct gprs_ns2_vc *nsvc, uint8_t *cause);<br>int gprs_ns2_tx_sns_size(struct gprs_ns2_vc *nsvc, bool reset_flag, uint16_t max_nr_nsvc,<br> int ip4_ep_nr, int ip6_ep_nr);<br>int gprs_ns2_tx_sns_size_ack(struct gprs_ns2_vc *nsvc, uint8_t *cause);<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">likewise all of those above. Those should be internal low-level functions inside the NS stack. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/19417">change 19417</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/19417"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3525beef205588dfab9d3880a34115f1a2676e48 </div>
<div style="display:none"> Gerrit-Change-Number: 19417 </div>
<div style="display:none"> Gerrit-PatchSet: 22 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Assignee: daniel <daniel@totalueberwachung.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-CC: daniel <daniel@totalueberwachung.de> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 07 Sep 2020 14:31:07 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>