This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19887 ) Change subject: mgcp_client: Use INET6_ADDRSTRLEN to store addresses in str format ...................................................................... mgcp_client: Use INET6_ADDRSTRLEN to store addresses in str format Warning: This breaks libosmo-mgcp-cli ABI! Related: SYS#4915 Change-Id: Ib778e9a72764103b52a462ea3c7fb56b23c1bcd6 --- M TODO-RELEASE M include/osmocom/mgcp_client/mgcp_client.h M include/osmocom/mgcp_client/mgcp_client_fsm.h M src/libosmo-mgcp-client/mgcp_client.c 4 files changed, 4 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index e44305b..8c7cd96 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -25,3 +25,4 @@ # #library what description / commit summary line osmo-mgw update osmo-gsm-manuals dependency to > 0.3.0 for vty_cpu_sched.adoc include +libosmo-mgcp-client mgcp_response, mgcp_conn_peer struct size change, breaks ABI diff --git a/include/osmocom/mgcp_client/mgcp_client.h b/include/osmocom/mgcp_client/mgcp_client.h index d4dd2d9..8914cc2 100644 --- a/include/osmocom/mgcp_client/mgcp_client.h +++ b/include/osmocom/mgcp_client/mgcp_client.h @@ -75,7 +75,7 @@ char *body; struct mgcp_response_head head; uint16_t audio_port; - char audio_ip[INET_ADDRSTRLEN]; + char audio_ip[INET6_ADDRSTRLEN]; unsigned int ptime; enum mgcp_codecs codecs[MGCP_MAX_CODECS]; unsigned int codecs_len; diff --git a/include/osmocom/mgcp_client/mgcp_client_fsm.h b/include/osmocom/mgcp_client/mgcp_client_fsm.h index a1ebbb6..e315753 100644 --- a/include/osmocom/mgcp_client/mgcp_client_fsm.h +++ b/include/osmocom/mgcp_client/mgcp_client_fsm.h @@ -15,7 +15,7 @@ * sure it is correct. */ struct mgcp_conn_peer { /*! RTP connection IP-Address (optional, string e.g. "127.0.0.1") */ - char addr[INET_ADDRSTRLEN]; + char addr[INET6_ADDRSTRLEN]; /*! RTP connection IP-Port (optional) */ uint16_t port; diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index b1909f0..146a59d 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -1121,7 +1121,7 @@ { unsigned int i; int rc = 0; - char local_ip[INET_ADDRSTRLEN]; + char local_ip[INET6_ADDRSTRLEN]; const char *codec; unsigned int pt; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19887 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib778e9a72764103b52a462ea3c7fb56b23c1bcd6 Gerrit-Change-Number: 19887 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200902/e88b81c3/attachment.htm>