<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/19887">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mgcp_client: Use INET6_ADDRSTRLEN to store addresses in str format<br><br>Warning: This breaks libosmo-mgcp-cli ABI!<br><br>Related: SYS#4915<br>Change-Id: Ib778e9a72764103b52a462ea3c7fb56b23c1bcd6<br>---<br>M TODO-RELEASE<br>M include/osmocom/mgcp_client/mgcp_client.h<br>M include/osmocom/mgcp_client/mgcp_client_fsm.h<br>M src/libosmo-mgcp-client/mgcp_client.c<br>4 files changed, 4 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/TODO-RELEASE b/TODO-RELEASE</span><br><span>index e44305b..8c7cd96 100644</span><br><span>--- a/TODO-RELEASE</span><br><span>+++ b/TODO-RELEASE</span><br><span>@@ -25,3 +25,4 @@</span><br><span> #</span><br><span> #library            what            description / commit summary line</span><br><span> osmo-mgw        update osmo-gsm-manuals dependency to > 0.3.0 for vty_cpu_sched.adoc include</span><br><span style="color: hsl(120, 100%, 40%);">+libosmo-mgcp-client     mgcp_response, mgcp_conn_peer   struct size change, breaks ABI</span><br><span>diff --git a/include/osmocom/mgcp_client/mgcp_client.h b/include/osmocom/mgcp_client/mgcp_client.h</span><br><span>index d4dd2d9..8914cc2 100644</span><br><span>--- a/include/osmocom/mgcp_client/mgcp_client.h</span><br><span>+++ b/include/osmocom/mgcp_client/mgcp_client.h</span><br><span>@@ -75,7 +75,7 @@</span><br><span>    char *body;</span><br><span>  struct mgcp_response_head head;</span><br><span>      uint16_t audio_port;</span><br><span style="color: hsl(0, 100%, 40%);">-    char audio_ip[INET_ADDRSTRLEN];</span><br><span style="color: hsl(120, 100%, 40%);">+       char audio_ip[INET6_ADDRSTRLEN];</span><br><span>     unsigned int ptime;</span><br><span>  enum mgcp_codecs codecs[MGCP_MAX_CODECS];</span><br><span>    unsigned int codecs_len;</span><br><span>diff --git a/include/osmocom/mgcp_client/mgcp_client_fsm.h b/include/osmocom/mgcp_client/mgcp_client_fsm.h</span><br><span>index a1ebbb6..e315753 100644</span><br><span>--- a/include/osmocom/mgcp_client/mgcp_client_fsm.h</span><br><span>+++ b/include/osmocom/mgcp_client/mgcp_client_fsm.h</span><br><span>@@ -15,7 +15,7 @@</span><br><span>  *  sure it is correct. */</span><br><span> struct mgcp_conn_peer {</span><br><span>       /*! RTP connection IP-Address (optional, string e.g. "127.0.0.1") */</span><br><span style="color: hsl(0, 100%, 40%);">-  char addr[INET_ADDRSTRLEN];</span><br><span style="color: hsl(120, 100%, 40%);">+   char addr[INET6_ADDRSTRLEN];</span><br><span> </span><br><span>     /*! RTP connection IP-Port (optional)  */</span><br><span>    uint16_t port;</span><br><span>diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c</span><br><span>index b1909f0..146a59d 100644</span><br><span>--- a/src/libosmo-mgcp-client/mgcp_client.c</span><br><span>+++ b/src/libosmo-mgcp-client/mgcp_client.c</span><br><span>@@ -1121,7 +1121,7 @@</span><br><span> {</span><br><span>         unsigned int i;</span><br><span>      int rc = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-     char local_ip[INET_ADDRSTRLEN];</span><br><span style="color: hsl(120, 100%, 40%);">+       char local_ip[INET6_ADDRSTRLEN];</span><br><span>     const char *codec;</span><br><span>   unsigned int pt;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-mgw/+/19887">change 19887</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-mgw/+/19887"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib778e9a72764103b52a462ea3c7fb56b23c1bcd6 </div>
<div style="display:none"> Gerrit-Change-Number: 19887 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>