Change in osmo-bts[master]: osmo-bts-trx/scheduler: fix comments related to FACCH/H and BFI

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/20981 )


Change subject: osmo-bts-trx/scheduler: fix comments related to FACCH/H and BFI
......................................................................

osmo-bts-trx/scheduler: fix comments related to FACCH/H and BFI

Change-Id: I1c1d81ba5a54946089da6c32b0d42141ffe71ed8
Related: OS#4799
---
M src/osmo-bts-trx/sched_lchan_tchh.c
1 file changed, 5 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/81/20981/1

diff --git a/src/osmo-bts-trx/sched_lchan_tchh.c b/src/osmo-bts-trx/sched_lchan_tchh.c
index 18d90bb..c7dac70 100644
--- a/src/osmo-bts-trx/sched_lchan_tchh.c
+++ b/src/osmo-bts-trx/sched_lchan_tchh.c
@@ -119,11 +119,13 @@
 	}
 	*mask = 0x0;
 
-	/* skip second of two TCH frames of FACCH was received */
+	/* skip decoding of the last 4 bursts of FACCH/H */
 	if (chan_state->ul_ongoing_facch) {
 		chan_state->ul_ongoing_facch = 0;
 		memcpy(*bursts_p, *bursts_p + 232, 232);
 		memcpy(*bursts_p + 232, *bursts_p + 464, 232);
+		/* we have already sent the first BFI when a FACCH/H frame
+		 * was decoded (see below), now send the second one. */
 		ber10k = 0;
 		memset(&meas_avg, 0, sizeof(meas_avg));
 		goto bfi;
@@ -266,8 +268,8 @@
 			meas_avg.ci_cb, ber10k,
 			PRES_INFO_UNKNOWN);
 bfi:
-		/* FIXME: a FACCH/H frame replaces two speech frames,
-		 * so we actually need to send two bad frame indications! */
+		/* A FACCH/H frame replaces two speech frames, so we need to send two BFIs.
+		 * One is sent here, another will be sent two bursts later (see above). */
 		if (rsl_cmode == RSL_CMOD_SPD_SPEECH) {
 			/* indicate bad frame */
 			if (lchan->tch.dtx.ul_sid) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20981
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1c1d81ba5a54946089da6c32b0d42141ffe71ed8
Gerrit-Change-Number: 20981
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201030/0d3c6130/attachment.htm>