<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20981">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo-bts-trx/scheduler: fix comments related to FACCH/H and BFI<br><br>Change-Id: I1c1d81ba5a54946089da6c32b0d42141ffe71ed8<br>Related: OS#4799<br>---<br>M src/osmo-bts-trx/sched_lchan_tchh.c<br>1 file changed, 5 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/81/20981/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/sched_lchan_tchh.c b/src/osmo-bts-trx/sched_lchan_tchh.c</span><br><span>index 18d90bb..c7dac70 100644</span><br><span>--- a/src/osmo-bts-trx/sched_lchan_tchh.c</span><br><span>+++ b/src/osmo-bts-trx/sched_lchan_tchh.c</span><br><span>@@ -119,11 +119,13 @@</span><br><span>   }</span><br><span>    *mask = 0x0;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        /* skip second of two TCH frames of FACCH was received */</span><br><span style="color: hsl(120, 100%, 40%);">+     /* skip decoding of the last 4 bursts of FACCH/H */</span><br><span>  if (chan_state->ul_ongoing_facch) {</span><br><span>               chan_state->ul_ongoing_facch = 0;</span><br><span>                 memcpy(*bursts_p, *bursts_p + 232, 232);</span><br><span>             memcpy(*bursts_p + 232, *bursts_p + 464, 232);</span><br><span style="color: hsl(120, 100%, 40%);">+                /* we have already sent the first BFI when a FACCH/H frame</span><br><span style="color: hsl(120, 100%, 40%);">+             * was decoded (see below), now send the second one. */</span><br><span>              ber10k = 0;</span><br><span>          memset(&meas_avg, 0, sizeof(meas_avg));</span><br><span>          goto bfi;</span><br><span>@@ -266,8 +268,8 @@</span><br><span>                      meas_avg.ci_cb, ber10k,</span><br><span>                      PRES_INFO_UNKNOWN);</span><br><span> bfi:</span><br><span style="color: hsl(0, 100%, 40%);">-             /* FIXME: a FACCH/H frame replaces two speech frames,</span><br><span style="color: hsl(0, 100%, 40%);">-            * so we actually need to send two bad frame indications! */</span><br><span style="color: hsl(120, 100%, 40%);">+          /* A FACCH/H frame replaces two speech frames, so we need to send two BFIs.</span><br><span style="color: hsl(120, 100%, 40%);">+            * One is sent here, another will be sent two bursts later (see above). */</span><br><span>           if (rsl_cmode == RSL_CMOD_SPD_SPEECH) {</span><br><span>                      /* indicate bad frame */</span><br><span>                     if (lchan->tch.dtx.ul_sid) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/20981">change 20981</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/20981"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1c1d81ba5a54946089da6c32b0d42141ffe71ed8 </div>
<div style="display:none"> Gerrit-Change-Number: 20981 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>