This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20852 ) Change subject: measurement: count all blocks as SUB for TCH/F in signalling mode ...................................................................... measurement: count all blocks as SUB for TCH/F in signalling mode SUB frames exist only in voice (or CSD) channels. When a TCH/F is in signalling mode, all blocks must be counted as SUB blocks. (for TCH/H the current implementation is correct.) Change-Id: I04be21200afa1d03afa0d7e476c66fa79cf42249 Related: OS#4799 --- M src/common/measurement.c 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/common/measurement.c b/src/common/measurement.c index 8a6da75..1805553 100644 --- a/src/common/measurement.c +++ b/src/common/measurement.c @@ -55,7 +55,6 @@ switch (lchan->type) { case GSM_LCHAN_TCH_F: switch (lchan->tch_mode) { - case GSM48_CMODE_SIGN: case GSM48_CMODE_SPEECH_V1: case GSM48_CMODE_SPEECH_EFR: if (trx_sched_is_sacch_fn(lchan->ts, fn, true)) @@ -67,6 +66,10 @@ if (trx_sched_is_sacch_fn(lchan->ts, fn, true)) return true; break; + case GSM48_CMODE_SIGN: + /* No DTX allowed; SUB=FULL, therefore measurements at all frame numbers are + * SUB */ + return true; default: LOGPFN(DMEAS, LOGL_ERROR, fn, "%s: Unsupported lchan->tch_mode %u\n", gsm_lchan_name(lchan), lchan->tch_mode); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20852 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I04be21200afa1d03afa0d7e476c66fa79cf42249 Gerrit-Change-Number: 20852 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201027/121fdbe1/attachment.htm>