<p>dexter <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20852">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">measurement: count all blocks as SUB for TCH/F in signalling mode<br><br>SUB frames exist only in voice (or CSD) channels. When a TCH/F is in<br>signalling mode, all blocks must be counted as SUB blocks. (for TCH/H<br>the current implementation is correct.)<br><br>Change-Id: I04be21200afa1d03afa0d7e476c66fa79cf42249<br>Related: OS#4799<br>---<br>M src/common/measurement.c<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/measurement.c b/src/common/measurement.c</span><br><span>index 8a6da75..1805553 100644</span><br><span>--- a/src/common/measurement.c</span><br><span>+++ b/src/common/measurement.c</span><br><span>@@ -55,7 +55,6 @@</span><br><span>       switch (lchan->type) {</span><br><span>    case GSM_LCHAN_TCH_F:</span><br><span>                switch (lchan->tch_mode) {</span><br><span style="color: hsl(0, 100%, 40%);">-           case GSM48_CMODE_SIGN:</span><br><span>               case GSM48_CMODE_SPEECH_V1:</span><br><span>          case GSM48_CMODE_SPEECH_EFR:</span><br><span>                         if (trx_sched_is_sacch_fn(lchan->ts, fn, true))</span><br><span>@@ -67,6 +66,10 @@</span><br><span>                      if (trx_sched_is_sacch_fn(lchan->ts, fn, true))</span><br><span>                           return true;</span><br><span>                         break;</span><br><span style="color: hsl(120, 100%, 40%);">+                case GSM48_CMODE_SIGN:</span><br><span style="color: hsl(120, 100%, 40%);">+                        /* No DTX allowed; SUB=FULL, therefore measurements at all frame numbers are</span><br><span style="color: hsl(120, 100%, 40%);">+                   * SUB */</span><br><span style="color: hsl(120, 100%, 40%);">+                     return true;</span><br><span>                 default:</span><br><span>                     LOGPFN(DMEAS, LOGL_ERROR, fn, "%s: Unsupported lchan->tch_mode %u\n",</span><br><span>                           gsm_lchan_name(lchan), lchan->tch_mode);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/20852">change 20852</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/20852"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I04be21200afa1d03afa0d7e476c66fa79cf42249 </div>
<div style="display:none"> Gerrit-Change-Number: 20852 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>