This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/20879 ) Change subject: Transceiver: explicitly set m{Tx,Rx}LowerLoopThread to NULL ...................................................................... Transceiver: explicitly set m{Tx,Rx}LowerLoopThread to NULL Coverity warns us that a non-static class members: - mRxLowerLoopThread, and - mTxLowerLoopThread, are not initialized in this constructor nor in any functions that it calls. I don't think it's critical, because we do initialize them in Transceiver::start(), but let's make them NULL. Change-Id: If9e06aa7965f17383ab6599c15945e8ce2703bbf Fixes: CID#214952 --- M Transceiver52M/Transceiver.cpp 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/79/20879/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 881633e..88e08ad 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -139,7 +139,8 @@ mTransmitLatency(wTransmitLatency), mRadioInterface(wRadioInterface), mChans(cfg->num_chans), mOn(false), mForceClockInterface(false), mTxFreq(0.0), mRxFreq(0.0), mTSC(0), mMaxExpectedDelayAB(0), - mMaxExpectedDelayNB(0), mWriteBurstToDiskMask(0) + mMaxExpectedDelayNB(0), mWriteBurstToDiskMask(0), + mTxLowerLoopThread(NULL), mRxLowerLoopThread(NULL), { txFullScale = mRadioInterface->fullScaleInputValue(); rxFullScale = mRadioInterface->fullScaleOutputValue(); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20879 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If9e06aa7965f17383ab6599c15945e8ce2703bbf Gerrit-Change-Number: 20879 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201024/c32eb02c/attachment.htm>