<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/20879">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Transceiver: explicitly set m{Tx,Rx}LowerLoopThread to NULL<br><br>Coverity warns us that a non-static class members:<br><br>  - mRxLowerLoopThread, and<br>  - mTxLowerLoopThread,<br><br>are not initialized in this constructor nor in any functions that<br>it calls.  I don't think it's critical, because we do initialize<br>them in Transceiver::start(), but let's make them NULL.<br><br>Change-Id: If9e06aa7965f17383ab6599c15945e8ce2703bbf<br>Fixes: CID#214952<br>---<br>M Transceiver52M/Transceiver.cpp<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/79/20879/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp</span><br><span>index 881633e..88e08ad 100644</span><br><span>--- a/Transceiver52M/Transceiver.cpp</span><br><span>+++ b/Transceiver52M/Transceiver.cpp</span><br><span>@@ -139,7 +139,8 @@</span><br><span>     mTransmitLatency(wTransmitLatency), mRadioInterface(wRadioInterface),</span><br><span>     mChans(cfg->num_chans), mOn(false), mForceClockInterface(false),</span><br><span>     mTxFreq(0.0), mRxFreq(0.0), mTSC(0), mMaxExpectedDelayAB(0),</span><br><span style="color: hsl(0, 100%, 40%);">-    mMaxExpectedDelayNB(0), mWriteBurstToDiskMask(0)</span><br><span style="color: hsl(120, 100%, 40%);">+    mMaxExpectedDelayNB(0), mWriteBurstToDiskMask(0),</span><br><span style="color: hsl(120, 100%, 40%);">+    mTxLowerLoopThread(NULL), mRxLowerLoopThread(NULL),</span><br><span> {</span><br><span>   txFullScale = mRadioInterface->fullScaleInputValue();</span><br><span>   rxFullScale = mRadioInterface->fullScaleOutputValue();</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/20879">change 20879</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/20879"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If9e06aa7965f17383ab6599c15945e8ce2703bbf </div>
<div style="display:none"> Gerrit-Change-Number: 20879 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>