Change in osmo-bts[master]: sched_lchan_tchf: count measurements for FACCH/F only once

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Oct 23 20:20:46 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20841 )

Change subject: sched_lchan_tchf: count measurements for FACCH/F only once
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/20841/3/src/osmo-bts-trx/sched_lchan_tchf.c 
File src/osmo-bts-trx/sched_lchan_tchf.c:

https://gerrit.osmocom.org/c/osmo-bts/+/20841/3/src/osmo-bts-trx/sched_lchan_tchf.c@245 
PS3, Line 245: If we are in SPEECH mode
So let's then make this memset() a part of the condition below ;)  Otherwise we always call it, even if we're in signalling mode (if the compiler is not smart enough to optimize this).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20841
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie3f2e620ba2a2ab2fecdbae627ef01c6128fce0b
Gerrit-Change-Number: 20841
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 23 Oct 2020 20:20:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201023/f0826d3a/attachment.htm>


More information about the gerrit-log mailing list