Change in osmo-bts[master]: sched_lchan_tchf: count measurements for FACCH/F only once

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Fri Oct 23 14:31:53 UTC 2020


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20841 )

Change subject: sched_lchan_tchf: count measurements for FACCH/F only once
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> This approach looks wrong to me, see my comments to https://gerrit.osmocom.org/c/osmo-bts/+/20840. Even if it makes the test cases pass, let's better discuss everything first.

In this case I think the approach is correct. For #20840 I am also not sure either. For this my Idea is that the FACCH replaces one TCH frame, with the data indication also the measurement is passed up. The BFI that is passed up at the same time should not contain a copy of the current measurement value. It should just not count. The problem is that the excess amount of measurement values generates incorrect measurement results, especially for SUB frames. (TC_meas_res_speech_tchf currently passes but that I think is because the measurements contain all the same results because the fake RSSI is constant throught the test, but in the log you will see that it looks ugly, measurement.c complains.)


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20841
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie3f2e620ba2a2ab2fecdbae627ef01c6128fce0b
Gerrit-Change-Number: 20841
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 23 Oct 2020 14:31:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201023/daecccf2/attachment.htm>


More information about the gerrit-log mailing list