Change in osmo-bts[master]: scheduler: get rid of useless TRX_CHAN_FLAG_PDCH

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Oct 19 15:04:23 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20721 )

Change subject: scheduler: get rid of useless TRX_CHAN_FLAG_PDCH
......................................................................

scheduler: get rid of useless TRX_CHAN_FLAG_PDCH

Change-Id: I951ec9b02be674936fbd0bf2e75b004813e25197
---
M include/osmo-bts/scheduler.h
M src/common/scheduler.c
2 files changed, 0 insertions(+), 4 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/include/osmo-bts/scheduler.h b/include/osmo-bts/scheduler.h
index f19a13e..6bb0b9b 100644
--- a/include/osmo-bts/scheduler.h
+++ b/include/osmo-bts/scheduler.h
@@ -8,8 +8,6 @@
 
 /* Whether a logical channel must be activated automatically */
 #define TRX_CHAN_FLAG_AUTO_ACTIVE	(1 << 0)
-/* Whether a logical channel belongs to PDCH (packet switched data) */
-#define TRX_CHAN_FLAG_PDCH		(1 << 1)
 
 /* FIXME: we should actually activate 'auto-active' channels */
 #define TRX_CHAN_IS_ACTIVE(state, chan) \
diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index 6d359e0..9af67c8 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -524,7 +524,6 @@
 		 * 05.03, chapter 5), regular interleaving as specified for xCCH.
 		 * NOTE: the burst buffer is three times bigger because the
 		 * payload of EDGE bursts is three times longer. */
-		.flags = TRX_CHAN_FLAG_PDCH,
 		.rts_fn = rts_data_fn,
 		.dl_fn = tx_pdtch_fn,
 		.ul_fn = rx_pdtch_fn,
@@ -539,7 +538,6 @@
 		 * transfer mode. On Downlink, the network sends timing advance
 		 * updates for several mobile stations. The coding scheme used
 		 * for PTCCH/D messages is the same as for PDTCH CS-1. */
-		.flags = TRX_CHAN_FLAG_PDCH,
 		.rts_fn = rts_data_fn,
 		.dl_fn = tx_pdtch_fn,
 		.ul_fn = rx_rach_fn,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20721
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I951ec9b02be674936fbd0bf2e75b004813e25197
Gerrit-Change-Number: 20721
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201019/73041128/attachment.htm>


More information about the gerrit-log mailing list