<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20721">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">scheduler: get rid of useless TRX_CHAN_FLAG_PDCH<br><br>Change-Id: I951ec9b02be674936fbd0bf2e75b004813e25197<br>---<br>M include/osmo-bts/scheduler.h<br>M src/common/scheduler.c<br>2 files changed, 0 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmo-bts/scheduler.h b/include/osmo-bts/scheduler.h</span><br><span>index f19a13e..6bb0b9b 100644</span><br><span>--- a/include/osmo-bts/scheduler.h</span><br><span>+++ b/include/osmo-bts/scheduler.h</span><br><span>@@ -8,8 +8,6 @@</span><br><span> </span><br><span> /* Whether a logical channel must be activated automatically */</span><br><span> #define TRX_CHAN_FLAG_AUTO_ACTIVE   (1 << 0)</span><br><span style="color: hsl(0, 100%, 40%);">-/* Whether a logical channel belongs to PDCH (packet switched data) */</span><br><span style="color: hsl(0, 100%, 40%);">-#define TRX_CHAN_FLAG_PDCH          (1 << 1)</span><br><span> </span><br><span> /* FIXME: we should actually activate 'auto-active' channels */</span><br><span> #define TRX_CHAN_IS_ACTIVE(state, chan) \</span><br><span>diff --git a/src/common/scheduler.c b/src/common/scheduler.c</span><br><span>index 6d359e0..9af67c8 100644</span><br><span>--- a/src/common/scheduler.c</span><br><span>+++ b/src/common/scheduler.c</span><br><span>@@ -524,7 +524,6 @@</span><br><span>                 * 05.03, chapter 5), regular interleaving as specified for xCCH.</span><br><span>             * NOTE: the burst buffer is three times bigger because the</span><br><span>           * payload of EDGE bursts is three times longer. */</span><br><span style="color: hsl(0, 100%, 40%);">-             .flags = TRX_CHAN_FLAG_PDCH,</span><br><span>                 .rts_fn = rts_data_fn,</span><br><span>               .dl_fn = tx_pdtch_fn,</span><br><span>                .ul_fn = rx_pdtch_fn,</span><br><span>@@ -539,7 +538,6 @@</span><br><span>           * transfer mode. On Downlink, the network sends timing advance</span><br><span>               * updates for several mobile stations. The coding scheme used</span><br><span>                * for PTCCH/D messages is the same as for PDTCH CS-1. */</span><br><span style="color: hsl(0, 100%, 40%);">-               .flags = TRX_CHAN_FLAG_PDCH,</span><br><span>                 .rts_fn = rts_data_fn,</span><br><span>               .dl_fn = tx_pdtch_fn,</span><br><span>                .ul_fn = rx_rach_fn,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/20721">change 20721</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/20721"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I951ec9b02be674936fbd0bf2e75b004813e25197 </div>
<div style="display:none"> Gerrit-Change-Number: 20721 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>